casaroli commented on code in PR #19673: URL: https://github.com/apache/nuttx/pull/19673#discussion_r3710075980
########## include/nuttx/lib/elf.h: ########## @@ -44,6 +44,16 @@ # define CONFIG_LIBC_ELF_MAXDEPEND 0 #endif +/* Holding an XIP pin past the load means holding the file itself: the pin is + * released when the module is unloaded, which happens on a task other than + * the one that loaded it, so a descriptor from that task's group cannot + * serve. That needs the file interface, which only the flat build has here. + */ + +#if defined(CONFIG_FDPIC) && defined(CONFIG_BUILD_FLAT) Review Comment: I have this working locally, however it required adding a syscall, so I think we should add it in a subsequent PR to not make this one larger. I will gate `FDPIC` on `BUILD_FLAT` for now. If you prefer, I can include the kernel and protected modes in this PR too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
