casaroli commented on PR #19673: URL: https://github.com/apache/nuttx/pull/19673#issuecomment-5206961883
> > > @cederom: Thank you @casaroli, please mark this change as Breaking Change, just in case something gets broken for someone they will know where to search for :-) > > > > > > @casaroli: I cannot apply the "breaking-change" label. could you apply it to this PR and to #19600? > > Done thanks :-) hello, this is not a breaking change anymore. it is a bug fix (now c++ constructors will work). it will break just if someone found a way around C++ constructors not working, then in this case, they would run twice. so i consider this not to be a breaking change anymore, and a bugfix instead. can you please remove the breaking-change tag? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
