(nuttx) branch releases/13.0 updated: arch/risc-v: fix uninitialized HW cmds and bus clock

[xiaoxiang]

This is an automated email from the ASF dual-hosted git repository.

xiaoxiang781216 pushed a commit to branch releases/13.0
in repository https://gitbox.apache.org/repos/asf/nuttx.git


The following commit(s) were added to refs/heads/releases/13.0 by this push:
     new 297e7625ab7 arch/risc-v: fix uninitialized HW cmds and bus clock
297e7625ab7 is described below

commit 297e7625ab759a076c33498b7c6c4e5c4644aa51
Author: Filipe Cavalcanti <filipe.cavalca...@espressif.com>
AuthorDate: Wed Aug 5 19:52:19 2026 -0300

    arch/risc-v: fix uninitialized HW cmds and bus clock
    
    Initialize i2c_ll_hw_cmd_t in sendstart/startrecv so ack_exp/done are
    not left with stack garbage that can NACK or skip the address byte.
    Program i2c_hal_set_bus_timing() with the requested bus_freq instead of
    the board default so msg frequency is applied.
    
    Affects only Espressif devices.
    
    Co-authored-by: Cursor <cursorag...@cursor.com>
    Signed-off-by: Filipe Cavalcanti <filipe.cavalca...@espressif.com>
---
 arch/risc-v/src/common/espressif/esp_i2c.c | 38 ++++++++++++++++++++----------
 1 file changed, 25 insertions(+), 13 deletions(-)

diff --git a/arch/risc-v/src/common/espressif/esp_i2c.c 
b/arch/risc-v/src/common/espressif/esp_i2c.c
index 5abb1ecd39a..3dc652c9916 100644
--- a/arch/risc-v/src/common/espressif/esp_i2c.c
+++ b/arch/risc-v/src/common/espressif/esp_i2c.c
@@ -563,19 +563,24 @@ static void esp_i2c_sendstart(struct esp_i2c_priv_s *priv)
 {
   struct i2c_msg_s *msg = &priv->msgv[priv->msgid];
   uint32_t fifo_val = 0;
-  i2c_ll_hw_cmd_t restart_cmd;
-  i2c_ll_hw_cmd_t write_cmd;
-  i2c_ll_hw_cmd_t end_cmd;
-
-  /* Write I2C command registers */
+  i2c_ll_hw_cmd_t restart_cmd =
+    {
+      .op_code = I2C_LL_CMD_RESTART
+    };
 
-  restart_cmd.op_code = I2C_LL_CMD_RESTART;
+  i2c_ll_hw_cmd_t write_cmd =
+    {
+      .byte_num = 1,
+      .ack_en = 1,
+      .op_code = I2C_LL_CMD_WRITE
+    };
 
-  write_cmd.byte_num = 1;
-  write_cmd.ack_en = 1;
-  write_cmd.op_code = I2C_LL_CMD_WRITE;
+  i2c_ll_hw_cmd_t end_cmd =
+    {
+      .op_code = I2C_LL_CMD_END
+    };
 
-  end_cmd.op_code = I2C_LL_CMD_END;
+  /* Write I2C command registers */
 
   i2c_ll_master_write_cmd_reg(priv->ctx->dev, restart_cmd, 0);
   i2c_ll_master_write_cmd_reg(priv->ctx->dev, write_cmd, 1);
@@ -688,8 +693,15 @@ static void esp_i2c_startrecv(struct esp_i2c_priv_s *priv)
   int ack_value = 0;
   struct i2c_msg_s *msg = &priv->msgv[priv->msgid];
   int n = msg->length - priv->bytes;
-  i2c_ll_hw_cmd_t read_cmd;
-  i2c_ll_hw_cmd_t end_cmd;
+  i2c_ll_hw_cmd_t read_cmd =
+    {
+      0
+    };
+
+  i2c_ll_hw_cmd_t end_cmd =
+    {
+      0
+    };
 
   if (n > 1)
     {
@@ -780,7 +792,7 @@ static void esp_i2c_init_clock(struct esp_i2c_priv_s *priv,
 
   I2C_CLOCK_SRC_ATOMIC()
     {
-      i2c_hal_set_bus_timing(priv->ctx, priv->config->clk_freq,
+      i2c_hal_set_bus_timing(priv->ctx, bus_freq,
                              priv->clk_src, src_clk_frequency);
     }