Fishwaldo opened a new pull request, #19860:
URL: https://github.com/apache/nuttx/pull/19860

   ## Summary
   
   The first five commits belong to #19745 and are not part of this change. This
   PR adds the last two.
   
   Nothing in the xHCI controller driver is PCI-specific beyond finding the
   registers and the interrupt, so an SoC that wires a controller directly could
   not use any of it.
   
   Two commits deliberately. The first is a pure `git mv` of 
`usbhost_xhci_pci.c`
   to `usbhost_xhci.c`, recorded as a rename so `git log --follow` keeps 
reaching
   the original driver history, together with the two build-file references so 
the
   commit still builds on its own. The second adds the new `usbhost_xhci_pci.c` 
-
   the ID table, the BAR mapping and the MSI-X vector - and makes the generic
   edits.
   
   `include/nuttx/usb/xhci.h` carries what passes between them: the register 
base,
   a way to attach the interrupt, and a name to report the controller by, since 
a
   system may have more than one. The interrupt belongs to the bus, which 
attaches
   and detaches it; the driver never holds an interrupt number, so there is
   nothing for the two sides to disagree about.
   
   `USBHOST_XHCI` is the driver and is not selectable on its own;
   `USBHOST_XHCI_PCI` selects it. Another bus adds its own symbol beside it.
   
   ## Impact
   
   No functional change intended. Existing configurations keep working through
   `USBHOST_XHCI_PCI`.
   
   ## Testing
   
   Built for `qemu-intel64:nsh` at both commits with the driver compiled and
   linked; the rename commit builds on its own, so the series stays bisectable.
   
   Run at the tip under QEMU with `-device qemu-xhci` and a `usb-storage` 
device,
   reading back `qemu-xhci-regression-ok` - unchanged from #19745, which is the
   point of a move.
   
   History is preserved:
   
   ```
   $ git log --follow --oneline drivers/usbhost/usbhost_xhci.c | tail -3
   ...
   0dccc8ba21 include/debug.h: Move to include/nuttx/debug.h
   fab4f68b6f drivers/usbhost: add xHCI support
   ```
   
   Depends-On: https://github.com/apache/nuttx/pull/19745
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to