Fishwaldo commented on code in PR #19860: URL: https://github.com/apache/nuttx/pull/19860#discussion_r3801075483
########## drivers/usbhost/CMakeLists.txt: ########## @@ -84,7 +84,7 @@ if(CONFIG_USBHOST) endif() if(CONFIG_USBHOST_XHCI_PCI) - list(APPEND SRCS usbhost_xhci_pci.c usbhost_xhci_trace.c) + list(APPEND SRCS usbhost_xhci.c usbhost_xhci_trace.c) Review Comment: The reason its split is to preserve git history. If I squash, there is too many changes and git will not reconcile its a rename and instead treat it as a new file (loosing all history). Happy to do that, but I thought preserving history here was important. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
