Abhishekmishra2808 commented on code in PR #19900:
URL: https://github.com/apache/nuttx/pull/19900#discussion_r3968491950
##########
fs/vfs/fs_rename.c:
##########
Review Comment:
Fixed in latest push.
##########
fs/vfs/fs_rename.c:
##########
Review Comment:
Fixed in latest push.
##########
fs/vfs/fs_rename.c:
##########
Review Comment:
Fixed in latest push.
##########
fs/vfs/fs_rename.c:
##########
Review Comment:
Fixed in latest push.
##########
fs/vfs/fs_rename.c:
##########
@@ -196,9 +200,15 @@ static int pseudorename(FAR const char *oldpath, FAR
struct inode *oldinode,
/* Re-resolve the source under the same lock before unlinking it. */
- SETUP_SEARCH(&olddesc, oldpath, true);
+ ret = inode_search_setup(&olddesc, oldpath, true);
+ if (ret < 0)
+ {
+ inode_search_release(&olddesc);
Review Comment:
Fixed in latest push.
##########
fs/vfs/fs_readlink.c:
##########
@@ -80,7 +80,12 @@ ssize_t readlink(FAR const char *path, FAR char *buf, size_t
bufsize)
* symbolic link node.
*/
- SETUP_SEARCH(&desc, path, true);
+ ret = inode_search_setup(&desc, path, true);
+ if (ret < 0)
+ {
+ errcode = -ret;
+ goto errout_with_search;
Review Comment:
Fixed in latest push.
##########
fs/vfs/fs_readlink.c:
##########
@@ -80,7 +80,12 @@ ssize_t readlink(FAR const char *path, FAR char *buf, size_t
bufsize)
* symbolic link node.
*/
- SETUP_SEARCH(&desc, path, true);
+ ret = inode_search_setup(&desc, path, true);
+ if (ret < 0)
+ {
+ errcode = -ret;
Review Comment:
Fixed in latest push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
