Abhishekmishra2808 commented on code in PR #19900:
URL: https://github.com/apache/nuttx/pull/19900#discussion_r3968496475
##########
fs/shm/shm_unlink.c:
##########
@@ -136,7 +140,7 @@ static int file_shm_unlink(FAR const char *name)
inode_release(inode);
errout_with_sem:
Review Comment:
Fixed in latest push.
##########
fs/shm/shm_open.c:
##########
@@ -165,7 +169,7 @@ static int file_shm_open(FAR struct file *shm, FAR const
char *name,
errout_with_sem:
Review Comment:
Fixed in latest push.
##########
fs/semaphore/sem_unlink.c:
##########
@@ -78,7 +78,12 @@ int nxsem_unlink(FAR const char *name)
/* Get the inode for this semaphore. */
- SETUP_SEARCH(&desc, fullpath, false);
+ ret = inode_search_setup(&desc, fullpath, false);
+ if (ret < 0)
+ {
+ inode_search_release(&desc);
Review Comment:
Fixed in latest push.
##########
fs/semaphore/sem_open.c:
##########
@@ -111,7 +111,12 @@ int nxsem_open(FAR sem_t **sem, FAR const char *name, int
oflags, ...)
* will have incremented the reference count on the inode.
*/
- SETUP_SEARCH(&desc, fullpath, false);
+ ret = inode_search_setup(&desc, fullpath, false);
+ if (ret < 0)
+ {
+ inode_search_release(&desc);
Review Comment:
Fixed in latest push.
##########
fs/mqueue/mq_unlink.c:
##########
@@ -113,7 +113,12 @@ int file_mq_unlink(FAR const char *mq_name)
/* Get the inode for this message queue. */
- SETUP_SEARCH(&desc, fullpath, false);
+ ret = inode_search_setup(&desc, fullpath, false);
+ if (ret < 0)
+ {
+ inode_search_release(&desc);
Review Comment:
Fixed in latest push.
##########
fs/mqueue/mq_open.c:
##########
@@ -235,7 +235,13 @@ static int file_mq_vopen(FAR struct file *mq, FAR const
char *mq_name,
* have incremented the reference count on the inode.
*/
- SETUP_SEARCH(&desc, fullpath, false);
+ ret = inode_search_setup(&desc, fullpath, false);
+ if (ret < 0)
+ {
+ inode_search_release(&desc);
Review Comment:
Fixed in latest push.
##########
fs/mqueue/mq_open.c:
##########
Review Comment:
Fixed in latest push.
##########
fs/mount/fs_umount2.c:
##########
@@ -72,7 +72,12 @@ int nx_umount2(FAR const char *target, unsigned int flags)
/* Find the mountpt */
- SETUP_SEARCH(&desc, target, false);
+ ret = inode_search_setup(&desc, target, false);
+ if (ret < 0)
+ {
+ inode_search_release(&desc);
Review Comment:
Fixed in latest push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
