Aurora-QIU0 commented on PR #20164:
URL: https://github.com/apache/nuttx/pull/20164#issuecomment-5708460651
The issues reported by the `check` job are fixed in `e1c5174`.
Because this PR touches `esp_i2c.c`, the pre-existing nxstyle violations in
that
file were addressed as well, per CONTRIBUTING.md section 2.1 ("adapt all
modified
files even if you did not introduce the problem yourself"):
* `1267` - statement over-indented inside its enclosing block (8
spaces where the block body is at 6)
* `1303`, `1592` - missing blank line after declarations
* `1710`-`1725` - `case`/`default` labels inside `switch (port)` were
aligned with the brace opening the switch body instead of one level further in
Verified locally with `tools/nxstyle.c` (gcc 13.3, Ubuntu 24.04): before the
change
the file reports 14 violations; afterwards
`nxstyle arch/risc-v/src/common/espressif/esp_i2c.c` exits 0 with no output.
All other ESP32-P4 / risc-v espressif files were left untouched.
The workflow runs for the new commit show `action_required` — would you mind
re-approving them when convenient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
