Aurora-QIU0 commented on PR #20164:
URL: https://github.com/apache/nuttx/pull/20164#issuecomment-5708560899
## Testing update 鈥?build and runtime logs (ESP32-P4, real hardware)
This change was built and exercised on hardware as part of the same ESP32-P4
bring-up as PR #20165. To be precise about what the hardware evidence does
and
does not show here:
* The runtime mask measurement was taken **after** this change was already
applied, and reads `171` (`0xab`) 鈥?i.e. it confirms the fixed value, not
the
original one. It is therefore not an isolated before/after for this hunk.
* The value of the original expression is a compile-time fact: every operand
is
a non-zero bit field, so `FUNCTION_2 || INPUT_PULLUP || OUTPUT_OPEN_DRAIN`
evaluates to `1`.
So the case for this hunk rests on that static analysis plus consistency with
the sibling drivers (`esp_i2c_slave.c`, `esp_i2c_bitbang.c`, `esp_spi.c`,
`esp_twai.c`, all of which use `|` for the same encodings) 鈥?supported by the
fact that the corrected mask is what the board was actually running on when
the
bus came up.
### Build
ninja: Building C object .../espressif/esp_i2c.c.o
-> libarch.a -> nuttx -> nuttx.bin
nuttx.bin 797756 bytes md5 0c4ac4e6c0df1ed695f9911a30e39c97
flash: "Wrote 797756 bytes" + "Hash of data verified" (rc=0)
### Runtime (same firmware as PR #20165)
I2CP[1] init enter id=0 scl=8 sda=7 attr_scl=171 attr_sda=171
I2CP[2] gpio cfg done scl_sig out=68 in=68 sda_sig out=69 in=69
GT911 touchscreen registered at /dev/input0 (polling mode)
nsh prompt reached; 0 panic / 0 assert / 0 ERROR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
