xiaoxiang781216 commented on code in PR #3803: URL: https://github.com/apache/nuttx-apps/pull/3803#discussion_r4141871365
########## examples/nxflat/tests/hello++/Makefile: ########## @@ -149,16 +149,20 @@ $(BIN3): $(BIN3).r2 # $(LDNXFLAT) $(LDNXFLATFLAGS) -o $@ $^ $(ROMFS_DIR)/$(BIN1): $(BIN1) - $(Q) install -D $(BIN1) $(ROMFS_DIR)/$(BIN1) + $(Q) mkdir -p $(ROMFS_DIR) Review Comment: could we merge nxflat/fdpic example/test into elf/so/ko examples/test? Actually, the same example/test should be able to generate the different format(nxflat/elf/fdpic) globally by CONFIG_NXFLAT/CONFIG_FDPIC etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
