casaroli commented on code in PR #3803: URL: https://github.com/apache/nuttx-apps/pull/3803#discussion_r4195110408
########## examples/nxflat/tests/hello++/Makefile: ########## @@ -149,16 +149,20 @@ $(BIN3): $(BIN3).r2 # $(LDNXFLAT) $(LDNXFLATFLAGS) -o $@ $^ $(ROMFS_DIR)/$(BIN1): $(BIN1) - $(Q) install -D $(BIN1) $(ROMFS_DIR)/$(BIN1) + $(Q) mkdir -p $(ROMFS_DIR) Review Comment: Yes I agree. I suggest we merge this as it is, and in a follow up PR I will move these into `examples/elf/tests`. By the way, should we rename `examples/elf` to `examples/module` or something else (because nxflat is not elf)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
