csanchezdll commented on code in PR #20367: URL: https://github.com/apache/nuttx/pull/20367#discussion_r4154273720
########## boards/arm/common/stm32/src/Make.defs: ########## @@ -215,6 +215,14 @@ endif ifeq ($(CONFIG_STM32_ROMFS),y) CSRCS += stm32_romfs_initialize.c +stm32_romfs_initialize.o: ../../../$(patsubst "%",%,$(CONFIG_STM32_ROMFS_IMAGEFILE)) +../../../../../apps/examples/elf/main/elf_romfs.img: Review Comment: Because `CONFIG_STM32_ROMFS_IMAGEFILE` setting on `boards/arm/stm32h7/nucleo-h743zi/configs/elf/defconfig` does not use APPSDIR either, but a relative path. make does not normalize paths when looking for targets, it uses string matching, so I need both to match. And APPSDIR is, normalized from what I have seen, but it is not defined as normalized, meaning it can or can not be. The goal here is to reuse `CONFIG_STM32_ROMFS_IMAGEFILE` from the defconfig, to avoid this mechanism triggering if the user configures a different rom image file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
