xiaoxiang781216 commented on code in PR #20417:
URL: https://github.com/apache/nuttx/pull/20417#discussion_r4162395596


##########
include/nuttx/fs/fs.h:
##########
@@ -147,6 +147,11 @@
 #define INODE_IS_NAMEDEVENT(i) INODE_IS_TYPE(i,FSNODEFLAG_TYPE_NAMEDEVENT)
 #define INODE_IS_HARDLINK(i)   INODE_IS_TYPE(i,FSNODEFLAG_TYPE_HARDLINK)
 
+#define FSNODEFLAG_RAWIO             0x00000010 /* Raw storage access       */

Review Comment:
   it's fine to add CAP_SYS_RAWIO, but why need FSNODEFLAG_RAWIO? we can just 
check whether inode type is BLOCK or MTD.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to