msli-dev commented on code in PR #20381: URL: https://github.com/apache/nuttx/pull/20381#discussion_r4170540525
########## drivers/mmcsd/mmcsd_sdio.c: ########## @@ -194,9 +194,7 @@ static int mmcsd_switch(FAR struct mmcsd_state_s *priv, uint32_t arg); /* Transfer helpers *********************************************************/ static bool mmcsd_wrprotected(FAR struct mmcsd_state_s *priv); -#if MMCSD_MULTIBLOCK_LIMIT != 1 Review Comment: I rebased the series onto current master (`8df6e2a3f4`) and fixed the conflict, retaining the upstream ioctl formatting and non-DMA setup error checks. I consolidated all `mmcsd_sdio.c` changes into the first, common patch (`44f3bccddf`), alongside the SDIO interface and MMC/SD Kconfig updates. The second patch (`294c46fc37`) now contains only the STM32H7 driver and its Kconfig changes. The existing sign-offs are preserved. The common-only STM32F7 build and the complete H743 builds with bounce enabled/disabled all pass without warnings. `checkpatch.sh` and `git diff --check` pass as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
