xiaoxiang781216 commented on code in PR #20594: URL: https://github.com/apache/nuttx/pull/20594#discussion_r4244244169
########## include/elf32.h: ########## @@ -36,28 +36,17 @@ * Pre-processor Definitions ****************************************************************************/ -#define ELF_CLASS ELFCLASS32 Review Comment: need define EI_NIDENT here to make https://github.com/apache/nuttx/pull/20594/changes#diff-c1e6614562064c1e2bdd3e0597f7f8edb5c94169ceb3448569b081717b95d6abR66 work. ########## include/elf32.h: ########## Review Comment: remove too ########## include/elf64.h: ########## Review Comment: need remove elf.h ########## include/elf32.h: ########## @@ -36,28 +36,17 @@ * Pre-processor Definitions ****************************************************************************/ -#define ELF_CLASS ELFCLASS32 Review Comment: could you reference the patch at: https://github.com/xiaoxiang781216/nuttx/commit/0c2318bf65868dc0990238f5b10e8c3e7d2e4953 https://github.com/xiaoxiang781216/nuttx/commit/98e698b5a9cf32cf2af91902c24c9a5ac34a2989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
