casaroli commented on code in PR #20594: URL: https://github.com/apache/nuttx/pull/20594#discussion_r4248101552
########## include/elf64.h: ########## Review Comment: Done. ########## include/elf32.h: ########## @@ -36,28 +36,17 @@ * Pre-processor Definitions ****************************************************************************/ -#define ELF_CLASS ELFCLASS32 Review Comment: Done: I took your two commits (0c2318bf and 98e698b5) with the author kept. elf32.h and elf64.h no longer include elf.h, and they define EI_NIDENT behind #ifndef, so they work alone and in any order with elf.h. I added a body to the SELFMAG commit, because checkpatch rejects a commit without one. I also removed the internal Change-Id and tracker lines. The other constants (SHN_XINDEX, SHN_LORESERVE, SHN_HIRESERVE, SHT_GROUP, SHT_SYMTAB_SHNDX) are in our commit on top. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
