casaroli opened a new pull request, #20743: URL: https://github.com/apache/nuttx/pull/20743
## Summary With `CONFIG_DISABLE_PTHREAD` and `CONFIG_SCHED_HAVE_PARENT`, `nxtask_sigchild()` calls `nxsig_tcbdispatch()` with two arguments, but the function has three, so the build fails: ``` task/task_exithook.c:251:7: error: too few arguments to function 'nxsig_tcbdispatch'; expected 3, have 2 ``` This PR passes the missing argument. `SIGCHLD` goes to the parent process, so `group_dispatch` is `true`, as in `group_signal()`. ## Impact Fixes the build of configurations with `CONFIG_DISABLE_PTHREAD` and `CONFIG_SCHED_HAVE_PARENT`. No defconfig in the tree has this combination today, so CI did not catch it. ## Testing `lm3s6965-ek:qemu-flat` with `CONFIG_DISABLE_PTHREAD=y` and `CONFIG_SCHED_HAVE_PARENT=y`: on master `task_exithook.c` fails to compile (above); with this PR every file compiles. `tools/checkpatch.sh -c -u -m -g` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
