xiaoxiang781216 commented on code in PR #20778: URL: https://github.com/apache/nuttx/pull/20778#discussion_r4307538392
########## libs/libc/unistd/CMakeLists.txt: ########## @@ -129,4 +129,14 @@ if(CONFIG_PIPES) list(APPEND SRCS lib_pipe.c) endif() +# dpopen() needs pipes, posix_spawn() and waitpid(). CONFIG_SYSTEM_POPEN +# selects the copy in apps/system/popen instead. Review Comment: let's remove apps/system/popen? ########## libs/libc/unistd/Make.defs: ########## @@ -78,6 +78,15 @@ ifeq ($(CONFIG_PIPES),y) CSRCS += lib_pipe.c endif +# dpopen() needs pipes, posix_spawn() and waitpid(). CONFIG_SYSTEM_POPEN +# selects the copy in apps/system/popen instead. Review Comment: if so, why not remove apps/system/popen? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
