casaroli commented on code in PR #20778: URL: https://github.com/apache/nuttx/pull/20778#discussion_r4308681126
########## libs/libc/unistd/CMakeLists.txt: ########## @@ -129,4 +129,14 @@ if(CONFIG_PIPES) list(APPEND SRCS lib_pipe.c) endif() +# dpopen() needs pipes, posix_spawn() and waitpid(). CONFIG_SYSTEM_POPEN +# selects the copy in apps/system/popen instead. Review Comment: Correction to the order: fastboot, the popen test and the popen example depend on `SYSTEM_POPEN`, and dhcpd and gdbstub test it in code. So first an apps PR lets them use either copy, then the defconfig PR, then the removal of apps/system/popen, then the guard. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
