xiaoxiang781216 commented on code in PR #20751: URL: https://github.com/apache/nuttx/pull/20751#discussion_r4306951873
########## libs/libc/ctype/lib_ctype.c: ########## @@ -32,12 +32,15 @@ * Macro Definitions ****************************************************************************/ -#ifndef CONFIG_LIBCXXTOOLCHAIN +#ifdef CONFIG_LIBC_CTYPE_TABLE -/* MSVC seems to conflict with these macros if defined in the public area. - * As such, they are defined in the private section to let NuttX build +/* With the toolchain C++ library these macros are defined by ctype.h. + * Otherwise they are defined here: MSVC seems to conflict with them if + * defined in the public area. */ +#ifndef CONFIG_LIBCXXTOOLCHAIN Review Comment: let's check `ifndef _U`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
