casaroli commented on code in PR #3886:
URL: https://github.com/apache/nuttx-apps/pull/3886#discussion_r4329028707
##########
Application.mk:
##########
@@ -27,15 +27,15 @@
ifneq ($(MAINSRC),)
ifeq ($(DYNLIB),y)
BUILD_MODULE = y
- MODAELFFLAGS = $(CMODULELFFLAGS)
- MODCFLAGS = $(CMODULEFLAGS)
- MODCXXFLAGS = $(CXXMODULEFLAGS)
+ MODAELFFLAGS = $(filter-out $(NOCOVERAGE),$(CMODULELFFLAGS))
Review Comment:
The options come from `ARCHOPTIMIZATION` in
`arch/arm/src/common/Toolchain.defs:77`, `arch/arm64/src/Toolchain.defs:142`
and `boards/sim/sim/sim/scripts/Make.defs:77`, and `CELFFLAGS`, `CMODULEFLAGS`
and the C++ versions copy `CFLAGS`
(`arch/arm/src/common/Toolchain.defs:635-647`,
`arch/arm64/src/Toolchain.defs:287-293`,
`boards/sim/sim/sim/scripts/Make.defs:255,288`). I can remove the options
there, in apache/nuttx#20813, with `$(filter-out $(ELF_NOCOVERAGE),$(CFLAGS))`.
Then this PR is not necessary, and crt0 needs no separate filter. But 13 arm
boards set `CELFFLAGS` or `CMODULEFLAGS` again from `$(CFLAGS)` in their
`Make.defs` (for example `boards/arm/stm32h7/openh743i/scripts/Make.defs:42`,
`boards/arm/imxrt/imxrt1170-evk/scripts/Make.defs:46`), so I must also change
them, or first remove these lines, which only repeat the arch values. Is that
OK for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
