casaroli commented on code in PR #3886:
URL: https://github.com/apache/nuttx-apps/pull/3886#discussion_r4331085876
##########
Application.mk:
##########
@@ -27,15 +27,15 @@
ifneq ($(MAINSRC),)
ifeq ($(DYNLIB),y)
BUILD_MODULE = y
- MODAELFFLAGS = $(CMODULELFFLAGS)
- MODCFLAGS = $(CMODULEFLAGS)
- MODCXXFLAGS = $(CXXMODULEFLAGS)
+ MODAELFFLAGS = $(filter-out $(NOCOVERAGE),$(CMODULELFFLAGS))
Review Comment:
Done in apache/nuttx#20813, without filter-out: the module options now end
with the options that turn coverage off (`-fno-profile-arcs
-fno-test-coverage`, clang: `-fno-profile-instr-generate
-fno-coverage-mapping`), as `libs/libbuiltin` does for its own runtime. The arm
and arm64 `Toolchain.defs` and the sim `Make.defs` add them to `CELFFLAGS`,
`CMODULEFLAGS` and the C++ versions when a module cannot use the coverage
runtime of the image, and `CMakeLists.txt` adds them to the ELF and module
compile options. With apps master and `CONFIG_COVERAGE_TOOLCHAIN`, `hello` as a
module now has no gcov symbol and runs; with `CONFIG_COVERAGE_MINI` it keeps
its coverage. apps needs no change, so I close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
