Sarthak-Pandey commented on code in PR #3859: URL: https://github.com/apache/nuttx-apps/pull/3859#discussion_r4329842371
########## interpreters/duktape/duk_cmdline.patch: ########## @@ -44,3 +124,33 @@ diff --color -ur duktape/src-noline/duk_config.h duktape-2.5.0-modifed/src-nolin -#define DUK_USE_DATE_PRS_STRPTIME +#undef DUK_USE_DATE_PRS_STRPTIME Review Comment: This is actually not a change introduced in this PR—it is pre-existing context in duk_cmdline.patch on master. Because duk_cmdline.patch is itself a diff file, git unified diff includes those preceding - and + lines as 3 lines of unchanged context above the new DUK_USE_INTERRUPT_COUNTER hunk, which GitHub renders in red/green. I haven't modified DUK_USE_DATE_PRS_STRPTIME. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
