Sarthak-Pandey commented on code in PR #3859: URL: https://github.com/apache/nuttx-apps/pull/3859#discussion_r4329969798
########## interpreters/duktape/duk_cmdline.patch: ########## @@ -44,3 +124,33 @@ diff --color -ur duktape/src-noline/duk_config.h duktape-2.5.0-modifed/src-nolin -#define DUK_USE_DATE_PRS_STRPTIME +#undef DUK_USE_DATE_PRS_STRPTIME #define DUK_USE_DATE_FMT_STRFTIME + + #if 0 /* XXX: safe condition? */ +@@ -2962,7 +2962,17 @@ typedef struct duk_hthread duk_context; + #undef DUK_USE_EXEC_INDIRECT_BOUND_CHECK Review Comment: Those are actually not new macros being added—they are pre-existing context lines from upstream duk_config.h right above DUK_USE_EXEC_TIMEOUT_CHECK. The #if 0 /* XXX: safe condition? */ line above the hunk header was a stray formatting artifact from the patch file. I have cleaned up the patch so only the necessary timeout and interrupt configurations are touched. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
