anatol commented on PR #3830:
URL: https://github.com/apache/nuttx-apps/pull/3830#issuecomment-6304241133

   > > @cederom Thank you for the feedback. PTAL.
   > 
   > Thank you @anatol :-)
   > 
   > * I have launched the CI.
   > * Build and runtime logs (extracts) are required in the PR description to 
show that code builds and runs. Your description looks like the code was not 
even built / run? Please provide your build and runtime logs.
   >   > Build host: Not run.
   >   > Target: Host-side executable; no NuttX board target.
   >   > Build and runtime logs: Not run. Add the host, compiler, and output 
here before submitting.
   > * This is new application (apache/nuttx-apps) and new functionality 
(apache/nuttx) that should be documented - with explanation what is does, how, 
why, and how to use it, with examples. Could you please provide documentation 
too for [testing: Add host fmaf regression program 
#3830](https://github.com/apache/nuttx-apps/pull/3830) and [libs/libm: Add 
fmaf, using fmadd.s on RISC-V targets with an FPU. 
nuttx#20553](https://github.com/apache/nuttx/pull/20553) ? Documentation is 
part of apache/nuttx repo and would require new PR after current ones are 
merged.
   
   Hello,
   
   thank you for your feedback. This test is a split of 
https://github.com/apache/nuttx/pull/20553 that adds the missing libm function.
   
   The code above been used as host testcase for the libm code i added and 
built/ran it about hundred times at this point. See the commit message part `   
 Tests: host C compiler build and run against system libm; 4,072,672 cases
       passed across four rounding modes.`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to