cederom commented on PR #3830: URL: https://github.com/apache/nuttx-apps/pull/3830#issuecomment-6305055231
> > > @cederom Thank you for the feedback. PTAL. > > > > > > Thank you @anatol :-) > > > > * I have launched the CI. > > * Build and runtime logs (extracts) are required in the PR description to show that code builds and runs. Your description looks like the code was not even built / run? Please provide your build and runtime logs. > > > Build host: Not run. > > > Target: Host-side executable; no NuttX board target. > > > Build and runtime logs: Not run. Add the host, compiler, and output here before submitting. > > * This is new application (apache/nuttx-apps) and new functionality (apache/nuttx) that should be documented - with explanation what is does, how, why, and how to use it, with examples. Could you please provide documentation too for [testing: Add host fmaf regression program #3830](https://github.com/apache/nuttx-apps/pull/3830) and [libs/libm: Add fmaf, using fmadd.s on RISC-V targets with an FPU. nuttx#20553](https://github.com/apache/nuttx/pull/20553) ? Documentation is part of apache/nuttx repo and would require new PR after current ones are merged. > > Hello, > > thank you for your feedback. This test is a split of [apache/nuttx#20553](https://github.com/apache/nuttx/pull/20553) that adds the missing libm function. There is no mention about new functionality in our Documentation (see [1], [2]). Please add some documentation so people interested in libm / fmaf could read how it works and how to use it. Here is an example PR where author added some code, documentation, and proof of working runtime https://github.com/apache/nuttx/pull/19911 :-) > The code above been used as host testcase for the libm code i added and built/ran it about hundred times at this point. See the commit message part ` Tests: host C compiler build and run against system libm; 4,072,672 cases passed across four rounding modes.` I could tell you that I ran 1/3 * 4,072,672 cases and you probably would want some logs from me - logs (extracts) really help greatly in the review. Just copy paste most important build and runtime information form the terminal so we know you did build and test the change yourself and that the PR is not fully and only generated by AI with no author verification.. thanks for understanding :-) Why I ask for that? Because your current description states clearly the code was not built and did not run either on host or target board, this may be language issue but also ai hallucination, see: > Build host: Not run. Target: Host-side executable; no NuttX board target. Build and runtime logs: Not run. Add the host, compiler, and output here before submitting. [1] https://nuttx.apache.org/docs/latest/index.html [2] https://nuttx.apache.org/docs/latest/contributing/documentation.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
