imeghar2408-max commented on PR #3840: URL: https://github.com/apache/nuttx-apps/pull/3840#issuecomment-6471010996
> > > @imeghar2408-max I'm confuse, the nxplayer already have support to play wav files, in fact that was the first type of format supported before mp3, as you can see on this video tutorial from 8 years ago: https://www.youtube.com/watch?v=8frPjqp75R8 > > > Maybe the Copilot is making a mistake. I suggest you to get a STM32F4Discovery board and test it before applying your patch. > > > > > > Ohh, Actuallyyyyyy My intention was to handle WAV files with extra RIFF chunks, rather than introduce WAV support from scratch. I've tested this on SIM ALSA BTW, but I haven't tested it on an STM32F4Discovery board. Maybe.. I'll get the board now... Thanks for the suggestion and the refer video, tho. > > Ahhh ok, one limitation was the wav file had to be in an specific sampling rate otherwise it didn't work, maybe if this solution works with any format, it will be nice yeah, exactly! that's the limitation i was trying to address. In the rn nxplayer path, the WAV sample rate isn't extracted before playback, so it falls back to the default... (smth 48 khz ig), My change reads the sample rate from the WAV header and checks whether the audio device supports it before starting playback. For now, it supports 16-bit PCM mono/stereo WAVs, not every WAV encoding tho... This is what i have tested on sim alsa... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
