parthitce commented on PR #19041: URL: https://github.com/apache/nuttx/pull/19041#issuecomment-6493994728
> we start removing iLLD from the beginning of this year and sync the plan to Infineon in Q3. This PR is opened in June, but you haven't mentioned the concern here that you have a completed version? > As I said many times, but I don't see the improvement in your PR(Please compare the change in this and https://github.com/apache/nuttx/pull/21110). > The patch which changes the current code base must split into small and self-contained patch, instead removing the origin cod base and apply the refresh new one. Feedbacks and reviews are always welcome. We are already splitting the changes in smaller fragments and PR's will be split. But that doesn't answer my primary question, why are you / @zhangyu-duck duplicating the efforts here? > Please note the current code base is running on the timing/life critical product. The current code base in upstream doesn't even compile for GCC and tasking! **Tasking:** ```bash command: cctc --pass-c=--make-target=./clock_sched_ticks.o -Em -o - '-Os' '--lsl-core=vtc' '--iso=99' '--language=+gcc,+volatile,-strings,-kanji' '--align=4' '--integer-enumeration' '--tradeoff=2' '--debug-info=default' '--keep-temporary-files' '-g' '--source' '--branch-target-align' '--fp-model=2' '--pass-c=--no-warnings=500,507,508,525,526,527,529,544,549,553,560,562,557,558,587,588,589' '--misrac-version=2004' '--user-mode=hypervisor' '--default-near-size=0' '-isystem' '/tmp/native-base/include' '-I' '/tmp/native-base/arch/tricore/src/illd/tc4xx/Libraries/src/Libraries/iLLD/TC4xx/Tricore/Cpu/Std' '-I' '/tmp/native-base/arch/tricore/src/illd/tc4xx/Libraries/src/Libraries/Infra/Platform' '-I' '/tmp/native-base/arch/tricore/src/illd/tc4xx/Libraries/src/Libraries/Infra/Platform/Compilers' '-I' '/tmp/native-base/arch/tricore/src/illd/tc4xx/Configurations' '-D__NuttX__' '-DNDEBUG' '-D__KERNEL__' '-O2' '-g3' '-DSCHED_LPWORKSTACKSECTION=CONFIG_SCHED_LPWORKSTACKSECTION' '-I' '/t mp/native-base/sched' ./clock/clock_sched_ticks.c cctc E205: don't know what to do with /tmp/native-base/include make[2]: *** [/tmp/native-base/tools/Config.mk:232: clock_gettime.ddc] Error 1 make[2]: *** [/tmp/native-base/tools/Config.mk:232: clock_systime_timespec.ddc] Error 1 make[2]: *** [/tmp/native-base/tools/Config.mk:232: clock_sched_ticks.ddc] Error 1 ERROR: cctc failed: 1 command: cctc --pass-c=--make-target=./clock_perf.o -Em -o - '-Os' '--lsl-core=vtc' '--iso=99' '--language=+gcc,+volatile,-strings,-kanji' '--align=4' '--integer-enumeration' '--tradeoff=2' '--debug-info=default' '--keep-temporary-files' '-g' '--source' '--branch-target-align' '--fp-model=2' '--pass-c=--no-warnings=500,507,508,525,526,527,529,544,549,553,560,562,557,558,587,588,589' '--misrac-version=2004' '--user-mode=hypervisor' '--default-near-size=0' '-isystem' '/tmp/native-base/include' '-I' '/tmp/native-base/arch/tricore/src/illd/tc4xx/Libraries/src/Libraries/iLLD/TC4xx/Tricore/Cpu/Std' '-I' '/tmp/native-base/arch/tricore/src/illd/tc4xx/Libraries/src/Libraries/Infra/Platform' '-I' '/tmp/native-base/arch/tricore/src/illd/tc4xx/Libraries/src/Libraries/Infra/Platform/Compilers' '-I' '/tmp/native-base/arch/tricore/src/illd/tc4xx/Configurations' '-D__NuttX__' '-DNDEBUG' '-D__KERNEL__' '-O2' '-g3' '-DSCHED_LPWORKSTACKSECTION=CONFIG_SCHED_LPWORKSTACKSECTION' '-I' '/tmp/nati ve-base/sched' ./clock/clock_perf.c make[2]: *** [/tmp/native-base/tools/Config.mk:232: clock_perf.ddc] Error 1 make[1]: *** [Makefile:74: .depend] Error 2 make: *** [tools/Unix.mk:695: pass2dep] Error 2 ``` **GCC CMake:** ```bash -- Successfully applied patch /tmp/native-base-orig/arch/tricore/src/tc3xx/../illd/tc3xx/patches/change_illd.patch. -- nuttx_add_subdirectory: Skipping cxx-oot-build -- Configuring done CMake Error at CMakeLists.txt:659 (add_executable): Cannot find source file: /tmp/native-base-orig/arch/tricore/src/illd/tc3xx/Libraries/src/Libraries/iLLD/TC3xx/Tricore/_PinMap/TC39x/IfxAsclin_PinMap_TC39xB_LFBGA292.c CMake Error at CMakeLists.txt:659 (add_executable): No SOURCES given to target: nuttx CMake Generate step failed. Build files cannot be regenerated correctly. ``` **GCC Make:** ```bash Create version.h Downloading: illd/tc3xx/illd.tar.gz LN: platform/board to /tmp/apps-master/platform/dummy Register: dd Register: nsh Register: sh Register: hello Register: ostest Register: getprime Unpacking: ILLD -- Successfully applied patch /tmp/native-base-orig/arch/tricore/src/illd/tc3xx/patches/change_illd.patch. In file included from illd/tc3xx/Libraries/src/Libraries/iLLD/TC3xx/Tricore/Scu/Std/IfxScuCcu.h:185, from illd/tc3xx/Libraries/src/Libraries/iLLD/TC3xx/Tricore/Stm/Std/IfxStm.h:124, from ./tc3xx/tc3xx_timerisr.c:35: illd/tc3xx/Libraries/src/Libraries/iLLD/TC3xx/Tricore/_PinMap/IfxScu_PinMap.h:39:10: fatal error: IfxScu_PinMap_TC39xB_LFBGA292.h: No such file or directory 39 | #include "IfxScu_PinMap_TC39xB_LFBGA292.h" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. In file included from illd/tc3xx/Libraries/src/Libraries/iLLD/TC3xx/Tricore/Scu/Std/IfxScuCcu.h:185, from illd/tc3xx/Libraries/src/Libraries/iLLD/TC3xx/Tricore/Asclin/Std/IfxAsclin.h:50, from illd/tc3xx/Libraries/src/Libraries/iLLD/TC3xx/Tricore/Asclin/Asc/IfxAsclin_Asc.h:233, from ./tc3xx/tc3xx_serial.c:46: illd/tc3xx/Libraries/src/Libraries/iLLD/TC3xx/Tricore/_PinMap/IfxScu_PinMap.h:39:10: fatal error: IfxScu_PinMap_TC39xB_LFBGA292.h: No such file or directory 39 | #include "IfxScu_PinMap_TC39xB_LFBGA292.h" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. ERROR: tricore-elf-gcc failed: 1 ERROR: tricore-elf-gcc failed: 1 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
