parthitce commented on PR #19041: URL: https://github.com/apache/nuttx/pull/19041#issuecomment-6496808891
> > @xiaoxiang781216 I think who submit the PR first should have priority, but in fact a bigger PR is more difficult to be reviewed and merged. @parthitce I think as a rule of thumb: instead of submitting all the changes in a single PR it is all better to divide in smaller PRs to make it easier to review and get merged. > > it is different that this pr remove ALL original code and apply the fresh implementation which is unacceptable before @parthitce modify the patch by change the current code base step by step, I will reject this PR get merged since the new code isn't run the full test at all. The original code come from @anchao when he work for LiAuto and extend by Xiaomi in the cumulative (not destruct) way. Didn't we agreed to split and break into multiple scope PR's already in this PR review including reverting the removal into native ones without iLLD? Also including the TASKING support as well. Isn't the review + align is the open source standards instead of duplicating the same work? Does that justify the duplicated efforts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
