xiaoxiang781216 commented on code in PR #21875:
URL: https://github.com/apache/nuttx/pull/21875#discussion_r4582562471


##########
arch/risc-v/src/Makefile:
##########
@@ -23,9 +23,9 @@
 include $(TOPDIR)/tools/Make.defs
 include chip/Make.defs
 ifeq ($(CONFIG_OPENSBI),y)
-include opensbi/Make.defs

Review Comment:
   move the dispatch to sbi/Make.def



##########
arch/risc-v/src/CMakeLists.txt:
##########
@@ -26,6 +26,10 @@ add_subdirectory(common)
 if(CONFIG_BUILD_KERNEL)
   add_subdirectory(sbi)
   target_include_directories(arch BEFORE PUBLIC ${NUTTX_CHIP_ABS_DIR} sbi)
+
+  if(CONFIG_NUTTSBI)

Review Comment:
   move into sbi/CMakeLists.txt



##########
arch/risc-v/src/CMakeLists.txt:
##########
@@ -26,6 +26,10 @@ add_subdirectory(common)
 if(CONFIG_BUILD_KERNEL)
   add_subdirectory(sbi)
   target_include_directories(arch BEFORE PUBLIC ${NUTTX_CHIP_ABS_DIR} sbi)

Review Comment:
   remove target_include_directories



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to