luojia65 commented on code in PR #21875:
URL: https://github.com/apache/nuttx/pull/21875#discussion_r4587042892


##########
arch/risc-v/src/sbi/CMakeLists.txt:
##########
@@ -21,13 +21,6 @@
 # 
##############################################################################
 
 if(CONFIG_NUTTSBI)
-
-  set(SRCS sbi_head.S sbi_mtrap.S sbi_vectors.S sbi_start.c)
-
-  list(APPEND SRCS sbi_mtimer.c sbi_mexception.c sbi_mcall.c sbi_mscratch.c)
-
-  list(APPEND SRCS sbi_ipi.c)
-
-  target_sources(arch PRIVATE ${SRCS})
-
+  add_subdirectory(nuttxsbi)
+  target_include_directories(arch BEFORE PUBLIC nuttxsbi)

Review Comment:
   I agree that we should move to the subfolder. As this project provides 
`nuttsbi` in former discussions and commits, I'll hold the name `nuttsbi` as 
the folder name. Note me if this is inappropriate. :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to