casaroli commented on code in PR #20668:
URL: https://github.com/apache/nuttx/pull/20668#discussion_r4587418277


##########
include/spawn.h:
##########
@@ -176,41 +176,95 @@ int posix_spawn_file_actions_addopen(
 
 int posix_spawnattr_init(FAR posix_spawnattr_t *attr);
 
-int posix_spawnattr_destroy(FAR posix_spawnattr_t *attr);
+static inline

Review Comment:
   These eleven functions are no longer symbols in libc. A link test that does 
not include <spawn.h> now fails, for example autoconf 
`AC_CHECK_FUNCS([posix_spawnattr_setsigmask])`, and objects built against the 
old header no longer link.
   
   Fix: keep the functions in libc, and put the fast path in spawn.h as 
function-like macros, which POSIX allows.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to