xiaoxiang781216 commented on code in PR #20668:
URL: https://github.com/apache/nuttx/pull/20668#discussion_r4633399490


##########
include/spawn.h:
##########
@@ -221,6 +221,113 @@ int posix_spawnattr_setstackaddr(FAR posix_spawnattr_t 
*attr,
 #  define posix_spawnattr_setstackaddr(attr, addr) (0)
 #endif
 
+/* The single-field accessors are also macros, so that callers including
+ * this header access the field directly.  The functions above stay in libc
+ * for callers that do not include it or take their address.
+ */
+
+static inline int __posix_spawnattr_destroy(FAR posix_spawnattr_t *attr)
+{
+  (void)attr;
+  return 0;
+}
+
+static inline

Review Comment:
   please follow spinlock approach to avoid the code duplication in header file 
and source file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to