zhangyu-duck commented on PR #21951: URL: https://github.com/apache/nuttx/pull/21951#issuecomment-6970422229
> NACK. This kind of rework is creating serious of huge conflict and problem with current Nuttx support. Have you tested with current upstream base HEAD or all your test results are based on downstream tree? > > ``` > AS: common/tasking/tricore_vectors.asm > astc E301: ["common/tasking/tricore_vectors.asm" 32] unknown C preprocessor directive used > astc E301: ["common/tasking/tricore_vectors.asm" 33] unknown C preprocessor directive used > astc E139: ["common/tasking/tricore_vectors.asm" 117] cannot emit expression in object file, replaced with integral value '0' > make[1]: *** [Makefile:135: tricore_vectors.o] Error 1 > ``` > > tcpu = up_cpu_index() is 0 without ARCH_HAVE_MULTICPU (AMP): every core reports CPU0. Before, the entry read CORE_ID. Most of these changes are aligned with your downstream BMP instead of current NuttX. > > Unnecessary changes : Renames .intvec -> .inttable, tricore_int_vector -> tricore_inttab, tricore_trap_vectors_cpuN -> tricore_traptab; all four linker scripts touched, collides with #21546. > > Implements the single trap table we deferred is in my TODO list as part of review comments from my PR which conflict the work. This objection is invalid. Reason 1: I have already addressed the multi-core issue—I will submit the relevant code later—but the current approach is certainly better than hardcoding it to 0. 2. Renaming `intvec` to `inttable` ensures consistency with `traptable`, which is an improvement. 3. Regarding the C preprocessor, I’ve already proposed merging this change, but you disagreed. As clearly stated in the PR description, I am making a concession here—I’ll wait for your preprocessor implementation. 4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
