zhangyu-duck commented on PR #21951: URL: https://github.com/apache/nuttx/pull/21951#issuecomment-6970830686
> > NACK. This kind of rework is creating serious of huge conflict and problem with current Nuttx support. Have you tested with current upstream base HEAD or all your test results are based on downstream tree? > > ``` > > AS: common/tasking/tricore_vectors.asm > > astc E301: ["common/tasking/tricore_vectors.asm" 32] unknown C preprocessor directive used > > astc E301: ["common/tasking/tricore_vectors.asm" 33] unknown C preprocessor directive used > > astc E139: ["common/tasking/tricore_vectors.asm" 117] cannot emit expression in object file, replaced with integral value '0' > > make[1]: *** [Makefile:135: tricore_vectors.o] Error 1 > > ``` > > > > > > > > > > > > > > > > > > > > > > > > tcpu = up_cpu_index() is 0 without ARCH_HAVE_MULTICPU (AMP): every core reports CPU0. Before, the entry read CORE_ID. Most of these changes are aligned with your downstream BMP instead of current NuttX. > > Unnecessary changes : Renames .intvec -> .inttable, tricore_int_vector -> tricore_inttab, tricore_trap_vectors_cpuN -> tricore_traptab; all four linker scripts touched, collides with #21546. > > Implements the single trap table we deferred is in my TODO list as part of review comments from my PR which conflict the work. > > #21510 what about merge this, but you disagree! > > > tcpu = up_cpu_index() is 0 without ARCH_HAVE_MULTICPU (AMP): every core reports CPU0. Before, the entry read CORE_ID. Most of these changes are aligned with your downstream BMP instead of current NuttX. > > > Unnecessary changes : Renames .intvec -> .inttable, tricore_int_vector -> tricore_inttab, tricore_trap_vectors_cpuN -> tricore_traptab; all four linker scripts touched, collides with #21546. > > > Implements the single trap table we deferred is in my TODO list as part of review comments from my PR which conflict the work. > > > > > > This objection is invalid. Reason 1: I have already addressed the multi-core issue—I will submit the relevant code later > > exactly the problem is this PR doesn't mentioned anything about it dependency or build failure with current master. > > 2. Renaming `intvec` to `inttable` ensures consistency with `traptable`, which is an improvement. > > Never against the improvement, as I have been struggling with the basic cleanup PR series to be merge the improvement shall be later which directly conflicting. you proposed to speed up the review process so the split PR of our changes will get merged and you will work on top of it. > > 3. Regarding the C preprocessor, I’ve already proposed merging this change, but you disagreed. As clearly stated in the PR description, I am making a concession here—I’ll wait for your preprocessor implementation. > > #21510 what about merge this, but you disagree! > > Because your PR is duplicated of our initial PR. Until yesterday this PR do have duplicate of my fix PR. > > All these circle backs to one point where our PR is still floating and your new PR or duplicate PR work creates more and more conflict enough to delay further. > #21510 what about merge this, but you disagree!??where i disagree -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
