ssekar15 commented on code in PR #22010: URL: https://github.com/apache/nuttx/pull/22010#discussion_r4624398693
########## arch/tricore/include/mpu.h: ########## Review Comment: the consumer of mpu.h is only in src/common, don't move this file to be inline with other architecture. ########## arch/tricore/src/common/tricore_mpu.c: ########## @@ -42,7 +42,7 @@ static unsigned int g_mpu_set; * Private Functions ****************************************************************************/ -static uint32_t get_dpre_value(unsigned int set) +static inline_function uint32_t get_dpre_value(unsigned int set) Review Comment: compilers automatically inline small static functions within the same .c file when optimizations are enabled, so inline is redundant here. And inline is used in all the API irrespective size (some are 150 lines) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
