Girinandha-M commented on code in PR #22010: URL: https://github.com/apache/nuttx/pull/22010#discussion_r4625050887
########## arch/tricore/include/arch.h: ########## @@ -75,6 +75,34 @@ * Public Types ****************************************************************************/ +#ifdef CONFIG_ARCH_ADDRENV +/* The task group resources are retained in a single structure, task_group_s + * that is defined in the header file nuttx/include/nuttx/sched.h. The type + * arch_addrenv_t must be defined by platform specific logic in + * nuttx/arch/<architecture>/include/arch.h. + * + * These tables would hold the physical address of the level 2 page tables. + * All would be initially NULL and would not be backed up with physical + * memory until mappings in the level 2 page table are required. + */ + +#ifdef CONFIG_ARCH_USE_MPU Review Comment: struct arch_addrenv_s is only defined under CONFIG_ARCH_USE_MPU, but ARCH_ADDRENV only depends on ARCH_HAVE_ADDRENV && SCHED_LPWORK. With ARCH_ADDRENV=y and ARCH_USE_MPU=n, every file fails: `include/nuttx/addrenv.h:273:25: error: field 'addrenv' has incomplete type` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
