cederom commented on PR #4092:
URL: https://github.com/apache/nuttx-apps/pull/4092#issuecomment-7041829974

   * Please use `depends-on:` tag, like "Depends-on: 
https://github.com/apache/nuttx/pull/22061."; in the PR description and the git 
commit message so automation can detect dependencies.
   
   Some hints from Claude please verify if that makes sense:
   * The Case 6 header comment says “a private encrypt followed by a public 
decrypt”, but the code encrypts with e and decrypts with d.
   * The RSA “sign” builds 00 02 padding, which is the PKCS#1 v1.5 encryption 
type (signatures use 00 01 FF…). The random bytes can also be zero, which 
type-2 padding doesn’t allow. The “hash” is the 24-byte g_message, not a 
digest. This is fine as a smoke test, but the comments call it a PKCS1 v1.5 
sign, which overstates it.
   * The comment in rsa_import_keyid about n/d being “larger than the key cache 
and go to flash directly” describes one particular driver. It belongs in the 
kernel driver, not in a generic test.
   In the ECDSA verify path, param[1] duplicates the public key ID and param[2] 
is NULL, with a comment saying param[1] is unused. Whether that’s correct can 
only be checked against the unmerged kernel PR.
   * On open() failure, crypto_free() calls close(-1) because it treats only 0 
as “unset”. This pattern is inherited from the other tests and is harmless.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to