ThePassionate commented on PR #4092: URL: https://github.com/apache/nuttx-apps/pull/4092#issuecomment-7042548058
Thanks for the thorough review. Addressed in ec76c0d433: 1. **depends-on tag**: added to the PR description. 2. **Case 6 comment**: fixed — it now correctly says "a public encrypt followed by a private decrypt". 3. **RSA sign/padding comments**: corrected — the comments now describe it as a raw private-key operation with type-2 padding, not a PKCS#1 v1.5 signature. 4. **rsa_import_keyid flash comment**: removed — implementation detail of a specific driver, not appropriate for a generic test. 5. **Keyid Kconfig depends**: the key-id mechanism (CRD_F_KEYID) is a generic interface — the software key store is currently the only backend, but a hardware backend (secure element, TEE) could implement the same interface without CRYPTO_CRYPTODEV_SOFTWARE_KEYMGMT. I'd rather not hard-depend on a specific backend here. 6. **Key cleanup on failure**: the ecdsa and rsa tests now clean up their keys on all error paths (goto cleanup labels). 7. **genkey without SOP_F_KEYID**: yes, intentional — CRK_GENERATE_SECP256R1_KEY creates a new key and always stores it in the key store (the two output parameters are the generated key ids); there is no key being referenced on input, so SOP_F_KEYID doesn't apply. Also fixed: the file is renamed to keymanagement.c (matching the vela naming) and uses Apache-2.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
