xiaoxiang781216 commented on a change in pull request #2061:
URL: https://github.com/apache/incubator-nuttx/pull/2061#discussion_r510560007
##########
File path: arch/arm/src/armv7-m/gnu/arm_exception.S
##########
@@ -321,9 +322,9 @@ exception_common:
.bss
.global g_intstackalloc
.global g_intstackbase
- .align 8
+ .balign 8
g_intstackalloc:
- .skip ((CONFIG_ARCH_INTERRUPTSTACK + 4) & ~7)
+ .skip (CONFIG_ARCH_INTERRUPTSTACK & ~7)
Review comment:
If the intension is aligned up, CONFIG_ARCH_INTERRUPTSTACK> 0 &&
CONFIG_ARCH_INTERRUPTSTACK < 7 is a correct stack value(even it's crazy that
the stack has 8 bytes, but it correct from logic). Yes, as I mention before the
key point is to use the alignup or aligndown consistently in all place, but
since algindown is use in many place and there isn't real difference between
alignup and aligndown, I would prefer to use the aligndown across the related
code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
