xiaoxiang781216 commented on a change in pull request #2061:
URL: https://github.com/apache/incubator-nuttx/pull/2061#discussion_r510564978
##########
File path: arch/arm/src/armv7-m/gnu/arm_lazyexception.S
##########
@@ -192,7 +192,8 @@ exception_common:
* here prohibits nested interrupts without some additional logic!
*/
- setintstack r2, r3
+ setintstack r2, r3 /* SP = IRQ stack top */
+ sub sp, #8 /* Adjust SP
(minus 8-byte offset) */
Review comment:
Yes, but it's right to let sp point to the pass of the end stack,
because AAPCS require all stack push must substract sp first before store the
value to stack.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
