davids5 commented on a change in pull request #3161:
URL: https://github.com/apache/incubator-nuttx/pull/3161#discussion_r600407096



##########
File path: boards/arm/stm32f7/nucleo-144/include/board.h
##########
@@ -508,5 +523,12 @@
 #define GPIO_ETH_RMII_TX_EN   GPIO_ETH_RMII_TX_EN_2
 #define GPIO_ETH_RMII_TXD0    GPIO_ETH_RMII_TXD0_2
 #define GPIO_ETH_RMII_TXD1    GPIO_ETH_RMII_TXD1_1
+#define GPIO_ETH_MII_COL      GPIO_ETH_COL_1

Review comment:
       Why are you adding an MMI signal to a RMII interface?
   
   The above table does not include this signal. If it is used, it should be in 
the table, if it is not on the HW is should be removed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to