gustavonihei commented on a change in pull request #3161:
URL: https://github.com/apache/incubator-nuttx/pull/3161#discussion_r601430567



##########
File path: arch/arm/src/stm32f7/stm32_adc.c
##########
@@ -735,7 +735,7 @@ static int adc_timinit(FAR struct stm32_dev_s *priv)
    *   position.
    */
 
-  ainfo("Initializing timers extsel = 0x%08x\n", priv->extsel);
+  ainfo("Initializing timers extsel = 0x%08lx\n", priv->extsel);

Review comment:
       @davids5 I posted my answer there: 
https://github.com/apache/incubator-nuttx/pull/3169#issuecomment-806616431
   
   So, in summary, for achieving the most standards-compliant and portable code:
   - Native integer types (int, unsigned...) **->** Specifiers from `fprintf` 
documentation (d, u....)
     - https://pubs.opengroup.org/onlinepubs/009695399/functions/fprintf.html
   - Fixed width integer types from `stdint.h` (int32_t, uint32_t...) **->** 
Specifiers from `inttypes.h` (PRId32, PRIu32)
     - https://en.cppreference.com/w/c/types/integer




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to