gustavonihei commented on a change in pull request #4332:
URL: https://github.com/apache/incubator-nuttx/pull/4332#discussion_r687923958
##########
File path: fs/driver/fs_blockpartition.c
##########
@@ -43,8 +43,8 @@
struct part_struct_s
{
FAR struct inode *parent;
- size_t firstsector;
- size_t nsectors;
+ off_t firstsector;
+ off_t nsectors;
Review comment:
`nsectors` represents a quantity, in this case the number of sectors. It
is not an actual offset.
It seems conceptually wrong to change it to `off_t`. It should be left as
`size_t`.
Besides, `size_t` length is machine-dependent, so it will already be 64-bit
wide on 64-bit machines.
https://godbolt.org/z/nndzd8T7P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
