xiaoxiang781216 commented on a change in pull request #4332:
URL: https://github.com/apache/incubator-nuttx/pull/4332#discussion_r688864881



##########
File path: fs/driver/fs_blockpartition.c
##########
@@ -43,8 +43,8 @@
 struct part_struct_s
 {
   FAR struct inode *parent;
-  size_t firstsector;
-  size_t nsectors;
+  off_t firstsector;
+  off_t nsectors;

Review comment:
       Yes, but it is normally 32bit on 32bit machine. size_t hasn't enough 
bits to rerepsent the block/flash device >= 2TB(assume sector size is 512B).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to