patacongo commented on a change in pull request #4693:
URL: https://github.com/apache/incubator-nuttx/pull/4693#discussion_r731793229
##########
File path: include/sys/types.h
##########
@@ -230,8 +230,10 @@ typedef uint16_t sa_family_t;
#ifdef CONFIG_SYSTEM_TIME64
typedef uint64_t clock_t;
+typedef int64_t time_t;
#else
typedef uint32_t clock_t;
+typedef int32_t time_t;
#endif
Review comment:
>
>
> time.h include sys/types.h at the begin, so there is no real difference
from the user perspective. putting here is to make all CONFIG_SYSTEM_TIME64
related public definition in the same place.
True.. the only difference is that one location complies with the
requirements of POSIX and the other does not. POSIX are requires the time_t
*not* be defined if time_t is not included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
