patacongo commented on a change in pull request #4693:
URL: https://github.com/apache/incubator-nuttx/pull/4693#discussion_r731862198
##########
File path: include/time.h
##########
@@ -102,7 +102,12 @@
/* Scalar types */
+#ifdef CONFIG_SYSTEM_TIME64
+typedef uint64_t time_t; /* Holds time in seconds */
+#else
typedef uint32_t time_t; /* Holds time in seconds */
+#endif
+
Review comment:
CONFIG_SYSTEM_TIME64 determines if the high precision system timer is
32- or 32-bits with. time_t is the number of seconds since the epoch. They
are unrelated. I don't see why the width of time_t should should be side of
effect and depend on the width of the high precision timer. Seems like a
unnecessary, undesirable coupling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
