xiaoxiang781216 commented on a change in pull request #5182:
URL: https://github.com/apache/incubator-nuttx/pull/5182#discussion_r780157173
##########
File path: drivers/ioexpander/ioe_dummy.c
##########
@@ -139,32 +142,32 @@ static void sim_interrupt(wdparm_t arg);
* well be pre-allocated.
*/
-static struct sim_dev_s g_ioexpander;
+static struct ioe_dummy_dev_s g_ioexpander;
/* I/O expander vtable */
-static const struct ioexpander_ops_s g_sim_ops =
+static const struct ioexpander_ops_s g_ioe_dummy_ops =
{
- sim_direction,
- sim_option,
- sim_writepin,
- sim_readpin,
- sim_readpin
+ ioe_dummy_direction,
Review comment:
Done for FOC driver. arch driver can relax the requirement since widely
used compiler support the new C version, but the common code is better to avoid
C99 only feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
