pkarashchenko commented on a change in pull request #5182:
URL: https://github.com/apache/incubator-nuttx/pull/5182#discussion_r780217854
##########
File path: drivers/ioexpander/ioe_dummy.c
##########
@@ -139,32 +142,32 @@ static void sim_interrupt(wdparm_t arg);
* well be pre-allocated.
*/
-static struct sim_dev_s g_ioexpander;
+static struct ioe_dummy_dev_s g_ioexpander;
/* I/O expander vtable */
-static const struct ioexpander_ops_s g_sim_ops =
+static const struct ioexpander_ops_s g_ioe_dummy_ops =
{
- sim_direction,
- sim_option,
- sim_writepin,
- sim_readpin,
- sim_readpin
+ ioe_dummy_direction,
Review comment:
The case is that C89 compatibility in such cases cost a lot if there are
similar function prototypes but there is a bug in initialization list. Like in
drivers/sensors/as5048b.c from
https://github.com/apache/incubator-nuttx/pull/5140
We are lucky that currently CI catches inconsistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
