xiaoxiang781216 commented on code in PR #6057:
URL: https://github.com/apache/incubator-nuttx/pull/6057#discussion_r849799136
##########
include/net/if.h:
##########
@@ -173,7 +187,7 @@ struct lifreq
uint8_t lifru_flags; /* Interface flags */
struct mii_ioctl_notify_s llfru_mii_notify; /* PHY event
notification */
struct mii_ioctl_data_s lifru_mii_data; /* MII request data */
- struct can_ioctl_data_s lifru_can_data; /* CAN bitrate request
data */
+ struct can_ioctl_bitrate_s lifru_can_data; /* CAN bitrate
request data */
Review Comment:
should we align the code like line 232-244
##########
.gitignore:
##########
@@ -5,6 +5,9 @@
*.d
!*.d/
*.dSYM
+*.ddc
Review Comment:
why add? please drop the change in .gitignore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]